Made improvements to combinations.py #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In relation to #3682 |
maths/combinations.py
Outdated
| # If either of the conditions are true, the function is being asked | ||
| # to calculate a factorial of a negative number, which is not possible | ||
| if n < k or k < 0: | ||
| print("Invalid value for n and/or k given.") |
There was a problem hiding this comment.
we should throw an exception instead of return -1.
There was a problem hiding this comment.
I'm kind of new to doctests in general, how do I make the doctest for an exception?
There was a problem hiding this comment.
Nvm think I got it
Co-authored-by: Du Yuanchao <[email protected]>
realDuYuanChao
approved these changes
Oct 26, 2020
|
@Rolv-Apneseth Thanks for your contribution :) |
|
No problem! |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Made improvements to combinations.py * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]> * Function now raises an error when given invalid input * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]>
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
* Made improvements to combinations.py * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]> * Function now raises an error when given invalid input * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* Made improvements to combinations.py * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]> * Function now raises an error when given invalid input * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]>
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Made improvements to combinations.py * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]> * Function now raises an error when given invalid input * Update maths/combinations.py Co-authored-by: Du Yuanchao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some improvements to combinations.py.
Added:
If you would like anything else, or if you don't like the changes, please let me know. Thanks!